[vm-repair] Return command warnings in the output payload (2.4.3) - #10340

🤖 PR Validation — ️✔️ All clear

Summary

vm-repair 2.4.3. Advisory warnings raised by a command are now returned in its output under a warnings key, not only written to the log.

The problem

az vm repair create warns when the repair VM size supports NVMe but not SCSI:

The repair VM size only supports NVMe. Repair scripts that select disks by the SCSI model string will not find the attached OS disk. Use --size to pick a size that supports SCSI, or verify the script handles NVMe.

That warning is real and consequential — several repair scripts in Azure/repair-script-library locate the attached OS disk by its SCSI model name, and on an NVMe-only repair VM they find nothing, complete, and report success. But the warning only ever reached the log. The returned JSON was a plain success payload:

{ "status": "SUCCESS", "repair_vm_name": "repair-scr5", ... }

So a script, harness, or portal experience driving az vm repair create had no way to know that the repair VM it just created is one that several repair scripts cannot work on. The only way to find out was to scrape stderr.

This surfaced during the PR #153 validation run in Azure/repair-script-library, where the warning fired on a Standard_D2ads_v6 repair VM and was visible to a human but not to the harness.

Changes

• azext_vm_repair/command_helper_class.py — the command helper carries a warnings list, and init_return_dict includes it. The key is omitted when there are no warnings, so existing output is byte-for-byte unchanged for every command that raises none.
• azext_vm_repair/custom.py — create records the disk-controller warning when the selection produces one. The log line is unchanged; this adds to the payload rather than moving anything.
• azext_vm_repair/tests/latest/test_returned_warnings.py — new.
• setup.py, HISTORY.rst — version and changelog.

Version & changelog

• setup.py VERSION: 2.4.2 -> 2.4.3
• HISTORY.rst entry added: yes

Testing

python -m unittest azext_vm_repair.tests.latest.test_returned_warnings \
                   azext_vm_repair.tests.latest.test_disk_controller_type \
                   azext_vm_repair.tests.latest.test_repair_utils
Ran 32 tests — OK

test_returned_warnings.py covers the three things that matter: the key is absent when nothing was raised, a raised warning comes back, and the returned list is a copy so a caller mutating it cannot corrupt the helper's state.

Run with the Azure CLI's bundled Python under unittest. azdev style and azdev linter were not run locally — azdev is not on the PATH in this environment, so CI will be the first to exercise them.

No live Azure tests were run.

Cross-repo impact (repair-script-library)

None. No run id, script path, or map.json change.

Security review

No new input handling. The only value added to the payload is a fixed message the extension itself produced; no caller-supplied string, resource name, or tag reaches it.

Backward compatibility

Additive. No command, parameter, default, or existing output key changes. A consumer that does not know about warnings sees exactly what it saw before, because the key only appears when a warning was raised.